Skip to content

CPP: No need to wait for a final transcript to be received in transcribe streaming#6025

Merged
DavidSouther merged 2 commits intoawsdocs:mainfrom
SergeyRyabinin:update_cpp_transcribe_sample
Feb 5, 2024
Merged

CPP: No need to wait for a final transcript to be received in transcribe streaming#6025
DavidSouther merged 2 commits intoawsdocs:mainfrom
SergeyRyabinin:update_cpp_transcribe_sample

Conversation

@SergeyRyabinin
Copy link
Copy Markdown
Contributor

starting the AWS CPP SDK version 1.11.252, the lines

                // Wait until the final transcript or an error is received.
                // Closing the stream prematurely will trigger an error.
                canCloseStream.WaitOne();

are no longer needed.
SDK now encodes and the sends the final empty frame that is accepted by a remote.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions github-actions Bot added the C++ This issue relates to the AWS SDK for C++ label Jan 30, 2024
@meyertst-aws meyertst-aws self-requested a review January 31, 2024 13:56
@meyertst-aws meyertst-aws self-assigned this Jan 31, 2024
@meyertst-aws meyertst-aws added Text Review not needed This contains no text which needs review Task A general update to the code base for language clarification, missing actions, tests, etc. labels Jan 31, 2024
@meyertst-aws meyertst-aws added the On Call Review needed This work needs an on-call review label Feb 2, 2024
@cpyle0819 cpyle0819 added On Call Review complete On call review complete and removed On Call Review needed This work needs an on-call review labels Feb 2, 2024
@cpyle0819 cpyle0819 force-pushed the update_cpp_transcribe_sample branch from daa6b9b to 8bb3aa4 Compare February 2, 2024 19:37
@DavidSouther DavidSouther merged commit 0a839a8 into awsdocs:main Feb 5, 2024
max-webster pushed a commit to max-webster/aws-doc-sdk-examples that referenced this pull request Mar 15, 2024
…ibe streaming (awsdocs#6025)

* No need to wait for a final transcript to be received starting the CPP SDK version 1.11.252


---------

Co-authored-by: Steven Meyer <108885656+meyertst-aws@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C++ This issue relates to the AWS SDK for C++ On Call Review complete On call review complete Task A general update to the code base for language clarification, missing actions, tests, etc. Text Review not needed This contains no text which needs review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants