Added the Java backend for weathertop2 #7604

scmacdon · 2025-09-29T18:20:00Z

This pull request adds Java backend for weathertop

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

beqqrry-aws · 2025-11-17T18:06:28Z

.tools/weathertop/backend/src/test/java/WeatheetopTest.java

@@ -0,0 +1,58 @@
+// Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.


File name has a typo:
WeatheetopTest.java should be WeatherTopTest.java

Update this file name to remove typo

tejasgn1 · 2025-11-26T10:30:17Z

.tools/weathertop/Readme.md

+- **Detailed Reports**: Generates a Dashboard in client app to inform you of the details such as pass rate for the SDKs, the overall number of tests, and so on.
+
+## Getting Started
+ToDO


Provide necessary info under Getting Started

tejasgn1 · 2025-11-26T10:33:11Z

.tools/weathertop/backend/src/main/java/com/weathertop/lambda/HandleRunFargateTask.java

+            FargateTaskRunner runner = new FargateTaskRunner();
+            String taskRunId = "";
+            if (language.compareTo("java") == 0) {
+                String clusteerName = "MyJavaWeathertopCluster";


typo; should be clusterName instead of clusteerName

the same typo is also at the next 6 else if conditions.

tejasgn1 · 2025-11-26T10:38:25Z

.tools/weathertop/backend/src/main/java/com/weathertop/service/FargateTaskRunner.java

+    private static final Region REGION = Region.US_EAST_1;
+
+    // Network config matching Python exactly
+    private static final List<String> SUBNETS = List.of(


is it required to hard code the subnet and security group config?

tejasgn1 · 2025-11-26T10:40:09Z

.tools/weathertop/backend/src/test/java/WeatheetopTest.java

@@ -0,0 +1,58 @@
+// Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.


Update this file name to remove typo

rlhagerm

See my comments and questions about the code.

Also, where is the code that writes the test outputs to S3? Is that in updated docker files, or somewhere else?

rlhagerm · 2025-12-02T14:35:03Z

.tools/weathertop/Readme.md

+- **Detailed Reports**: Generates a Dashboard in client app to inform you of the details such as pass rate for the SDKs, the overall number of tests, and so on.
+
+## Getting Started
+ToDO


I'd like to see more detail here, such as a section on deployment, and one on logging. This is a place to describe how to work with the code, not just the overview and features.

rlhagerm · 2025-12-02T14:37:47Z

.tools/weathertop/backend/src/main/java/com/weathertop/lambda/HandleEventBridgeInspector.java

+                            "ecs-java-schedule"
+                    );
+
+                    Map<String, Object> data = inspector.inspect();


These 12 lines of code are repeated 10 times, can they be consolidated by using variables within the switch and then the inspector/json/response return all in one place at the end to make it more maintainable?

rlhagerm · 2025-12-02T14:39:10Z

.tools/weathertop/backend/src/main/java/com/weathertop/lambda/HandleEventBridgeInspector.java

+                    logger.log("Processing Java SDK EventBridge Inspector");
+
+                    EcsEventBridgeInspector inspector = new EcsEventBridgeInspector(
+                            "MyJavaWeathertopCluster",


For all of these hardcoded resource names, is there a deployment stack somewhere to ensure they are deployed correctly with all the right names?

rlhagerm · 2025-12-02T14:42:17Z

.tools/weathertop/backend/src/main/java/com/weathertop/lambda/HandleEventBridgeScheduler.java

+            }
+
+            String taskDefinitionArnVal = queryParams.get("taskDefinitionArnVal").toLowerCase(); // Normalize
+            String clusterName = queryParams.get("clusterName").toLowerCase();


The variable clusterName is forced to lower case, but then it is compared to values that are not all lower case, like "MyNetWeathertopCluster". How does this ever match?

rlhagerm · 2025-12-02T14:43:36Z

.tools/weathertop/backend/src/main/java/com/weathertop/lambda/HandleEventBridgeScheduler.java

+            } else if (clusterName.equals("MyRustWeathertopCluster")) {
+                ruleName = "ecs-rust-schedule";
+            } else {
+                ruleName = "ecs-java-schedule";


This doesn't look like enough languages. Where are PHP, CPP, Python, etc?

rlhagerm · 2025-12-02T15:01:07Z

.tools/weathertop/backend/src/main/java/com/weathertop/service/FargateDeployer.java

+    private static final String AWS_ACCOUNT_ID = "814548047983";
+    private static final String AWS_REGION = "us-east-1";
+    private static final String CLUSTER_NAME = "MyJavaWeathertopCluster";
+    private static final String TASK_DEF_NAME = "WeathertopJava";


Does this deploy some resources for Java? What about other languages? And where is this called?

rlhagerm · 2025-12-02T15:02:12Z

.tools/weathertop/backend/src/main/java/com/weathertop/service/FargateDeployer.java

+        ensureLogGroup();
+        String taskDefArn = registerTaskDefinition();
+        createOrUpdateService(clusterArn, taskDefArn);
+        System.out.println("✅ ECS Fargate deployment complete.");


rlhagerm · 2025-12-02T15:02:38Z

.tools/weathertop/backend/src/main/java/com/weathertop/service/FargateDeployer.java

+
+public class FargateDeployer {
+
+    private static final String AWS_ACCOUNT_ID = "814548047983";


Hard-coded account?

rlhagerm · 2025-12-02T15:05:48Z

.tools/weathertop/backend/src/main/java/com/weathertop/service/FargateTaskRunner.java

+
+        if (!response.tasks().isEmpty()) {
+            String taskArn = response.tasks().get(0).taskArn();
+            System.out.println("🚀 Started task: " + taskArn);


Check all code for emojis.

rlhagerm · 2025-12-02T15:12:43Z

.tools/weathertop/backend/src/main/java/com/weathertop/service/QueryLatestFromS3.java

+    * @return the key of the latest file that matches the pattern
+    * @throws RuntimeException if no matching files are found for the given prefix
+    */
+    public static String getLatestFileKey(S3Client s3Client, String bucketName, String languagePrefix) {


Why are there multiple copies of both getLatestFileKey and extractTimestamp? If they are common utilities, let's put them in a common location.

added the Java backend for weathertop2

ceb4824

scmacdon self-assigned this Sep 29, 2025

scmacdon added Java-v2 This issue relates to the AWS SDK for Java V2 Tools This issue relates to a custom tooling to streamline development tasks labels Sep 29, 2025

github-actions bot removed the Java-v2 This issue relates to the AWS SDK for Java V2 label Sep 29, 2025

scmacdon added 2 commits September 29, 2025 14:23

fixed a linter issue

0fee2a7

fixed a linter issue

0259983

scmacdon requested a review from tejasgn1 September 29, 2025 18:57

beqqrry-aws reviewed Nov 17, 2025

View reviewed changes

tejasgn1 reviewed Nov 26, 2025

View reviewed changes

brmur requested a review from rlhagerm December 1, 2025 15:30

rlhagerm requested changes Dec 2, 2025

View reviewed changes

		@@ -0,0 +1,58 @@
		// Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.


		public class FargateDeployer {

		private static final String AWS_ACCOUNT_ID = "814548047983";

Added the Java backend for weathertop2 #7604

Are you sure you want to change the base?

Added the Java backend for weathertop2 #7604

Uh oh!

Conversation

scmacdon commented Sep 29, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rlhagerm left a comment

Choose a reason for hiding this comment

Uh oh!

rlhagerm Dec 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rlhagerm Dec 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

rlhagerm Dec 2, 2025 •

edited

Loading

rlhagerm Dec 2, 2025 •

edited

Loading