fix: persist tool_result messages to storage during tool processing#445
Open
guoyangzhen wants to merge 8 commits intoawslabs:mainfrom
Open
fix: persist tool_result messages to storage during tool processing#445guoyangzhen wants to merge 8 commits intoawslabs:mainfrom
guoyangzhen wants to merge 8 commits intoawslabs:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Only USER input and final ASSISTANT response were saved to chat storage. Tool_result messages created during tool processing were kept in-memory only, so subsequent requests loaded incomplete conversation history.
This caused Bedrock/Anthropic API errors:
Root Cause
The orchestrator's
save_messageonly saves the user input and final agent response. Thetool_response(USER role with tool results) created by_process_tool_blockis added to the in-memory conversation for the next LLM call but never persisted to storage.Fix
tool_responsemessages inAgent._pending_tool_responsesduring tool processing loopsFiles changed: 8 files (+66 lines)
Fixes #396