test: Add unit tests for Python BedrockClassifier#449
Open
amandladev wants to merge 1 commit intoawslabs:mainfrom
Open
test: Add unit tests for Python BedrockClassifier#449amandladev wants to merge 1 commit intoawslabs:mainfrom
amandladev wants to merge 1 commit intoawslabs:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Python BedrockClassifier is the primary AWS-native classifier in the framework, yet it had zero dedicated test coverage — unlike its AnthropicClassifier counterpart which already has a full test suite. This PR adds 27 unit tests covering initialization, the Bedrock Converse API integration (tool schema, toolChoice branching per model family), error handling BotoCoreError, ClientError, malformed responses), callback lifecycle, and edge cases. All tests use mocked boto3 clients, so no AWS credentials are needed to run them. This closes a notable gap in test parity across classifiers and helps catch regressions in a core code path.
Fixes #448
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.