More robust sample testing nodejs #427
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+31
to
+38
| elif [[ "$RUNNER_OS" == "Linux" ]]; then | ||
| cd samples/basic_sample/consumer | ||
| KCL_COMMAND="../../../bin/kcl-bootstrap -e -p ./sample.properties" | ||
| timeout 300 $KCL_COMMAND 2>&1 | tee kcl_output.log || [ $? -eq 124 ] | ||
| elif [[ "$RUNNER_OS" == "Windows" ]]; then | ||
| cd samples/basic_sample/consumer | ||
| KCL_COMMAND="../../../bin/kcl-bootstrap -e -p ./sample.properties" | ||
| timeout 300 $KCL_COMMAND 2>&1 | tee kcl_output.log || [ $? -eq 124 ] |
There was a problem hiding this comment.
These look to be the same commands, can we put an or in the if statement instead to reduce copy paste?
Comment on lines
+6
to
+23
| if [[ "$RUNNER_OS" == "macOS" ]]; then | ||
| sed -i "" "s/streamName = .*/streamName = $STREAM_NAME/" samples/basic_sample/consumer/sample.properties | ||
| sed -i "" "s/applicationName = .*/applicationName = $APP_NAME/" samples/basic_sample/consumer/sample.properties | ||
| sed -i "" "s/#*idleTimeBetweenReadsInMillis.*/idleTimeBetweenReadsInMillis = 250/" samples/basic_sample/consumer/sample.properties | ||
| sed -i "" "s/stream : 'kclnodejssample'/stream : '$STREAM_NAME'/" samples/basic_sample/producer/config.js | ||
| sed -i "" "s/shards : 2/shards : 1/" samples/basic_sample/producer/config.js | ||
| elif [[ "$RUNNER_OS" == "Linux" ]]; then | ||
| sed -i "s/streamName = .*/streamName = $STREAM_NAME/" samples/basic_sample/consumer/sample.properties | ||
| sed -i "s/applicationName = .*/applicationName = $APP_NAME/" samples/basic_sample/consumer/sample.properties | ||
| sed -i "s/#*idleTimeBetweenReadsInMillis.*/idleTimeBetweenReadsInMillis = 250/" samples/basic_sample/consumer/sample.properties | ||
| sed -i "s/stream : 'kclnodejssample'/stream : '$STREAM_NAME'/" samples/basic_sample/producer/config.js | ||
| sed -i "s/shards : 2/shards : 1/" samples/basic_sample/producer/config.js | ||
| elif [[ "$RUNNER_OS" == "Windows" ]]; then | ||
| sed -i "s/streamName = .*/streamName = $STREAM_NAME/" samples/basic_sample/consumer/sample.properties | ||
| sed -i "s/applicationName = .*/applicationName = $APP_NAME/" samples/basic_sample/consumer/sample.properties | ||
| sed -i "s/#*idleTimeBetweenReadsInMillis.*/idleTimeBetweenReadsInMillis = 250/" samples/basic_sample/consumer/sample.properties | ||
| sed -i "s/stream : 'kclnodejssample'/stream : '$STREAM_NAME'/" samples/basic_sample/producer/config.js | ||
| sed -i "s/shards : 2/shards : 1/" samples/basic_sample/producer/config.js |
There was a problem hiding this comment.
Are these all the same commands? Can we merge them all under one if statement so we don't repeat code?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Added more robust checks for kcl functionality.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.