Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding @PreDestroy annotation to public facing shutdown methods #18

Closed
wants to merge 2 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -1 +1,5 @@
/target/
.idea
.classpath
.project
*.iml
Original file line number Diff line number Diff line change
@@ -1,12 +1,13 @@
package com.amazonaws.services.sqs;

import com.amazonaws.services.sqs.model.Message;
import com.amazonaws.services.sqs.model.SendMessageRequest;

import javax.annotation.PreDestroy;
import java.util.concurrent.CompletableFuture;
import java.util.concurrent.TimeUnit;
import java.util.concurrent.TimeoutException;

import com.amazonaws.services.sqs.AmazonSQS;
import com.amazonaws.services.sqs.model.Message;
import com.amazonaws.services.sqs.model.SendMessageRequest;

public interface AmazonSQSRequester {

Expand All @@ -26,5 +27,6 @@ public Message sendMessageAndGetResponse(SendMessageRequest request,
public CompletableFuture<Message> sendMessageAndGetResponseAsync(SendMessageRequest request,
int timeout, TimeUnit unit);

@PreDestroy
public void shutdown();
}
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@
import com.amazonaws.services.sqs.util.SQSMessageConsumer;
import com.amazonaws.services.sqs.util.SQSQueueUtils;

import javax.annotation.PreDestroy;

/**
* Implementation of the request/response interfaces that creates a single
* temporary queue for each response message.
Expand Down Expand Up @@ -76,7 +78,7 @@ public CompletableFuture<Message> sendMessageAndGetResponseAsync(SendMessageRequ
sqs.sendMessage(requestWithResponseUrl);

CompletableFuture<Message> future = new CompletableFuture<>();

// TODO-RS: accept an AmazonSQSAsync instead and use its threads instead of our own.
// TODO-RS: complete the future exceptionally, for the right set of SQS exceptions
SQSMessageConsumer consumer = new ResponseListener(responseQueueUrl, future);
Expand Down Expand Up @@ -110,6 +112,7 @@ protected void runShutdownHook() {
}

@Override
@PreDestroy
public void shutdown() {
responseConsumers.forEach(SQSMessageConsumer::terminate);
if (shutdownHook != null) {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
package com.amazonaws.services.sqs;

import com.amazonaws.services.sqs.AmazonSQS;
import javax.annotation.PreDestroy;

public interface AmazonSQSResponder {

Expand All @@ -21,5 +21,6 @@ public interface AmazonSQSResponder {
*/
public void sendResponseMessage(MessageContent requestMessage, MessageContent response);

@PreDestroy
public void shutdown();
}
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@
import com.amazonaws.services.sqs.model.QueueDoesNotExistException;
import com.amazonaws.services.sqs.model.SendMessageRequest;

import javax.annotation.PreDestroy;

class AmazonSQSResponderClient implements AmazonSQSResponder {

private static final Log LOG = LogFactory.getLog(AmazonSQSResponderClient.class);
Expand Down Expand Up @@ -49,6 +51,7 @@ public boolean isResponseMessageRequested(MessageContent requestMessage) {
}

@Override
@PreDestroy
public void shutdown() {
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@
import java.util.concurrent.atomic.AtomicBoolean;
import java.util.function.Consumer;

import javax.annotation.PreDestroy;

import com.amazonaws.services.sqs.AmazonSQS;
import com.amazonaws.services.sqs.model.Message;
import com.amazonaws.services.sqs.model.QueueDoesNotExistException;
Expand Down Expand Up @@ -165,7 +167,8 @@ private void handleMessage(Message message) {
protected void accept(Message message) {
consumer.accept(message);
}


@PreDestroy
public void shutdown() {
if (shuttingDown.compareAndSet(false, true)) {
runShutdownHook();
Expand Down