Skip to content

Conversation

@xiazhvera
Copy link
Contributor

@xiazhvera xiazhvera commented Oct 31, 2025

Issue #, and/or reason for changes (REQUIRED):

Description of changes:
Extend aws_get_platform_build_os_string to return platform string with architecture information.

String choices follow common industry conventions:

  • "Windows" - Microsoft Windows family
  • "macOS" - Apple macOS
  • "iOS" - Apple iOS
  • "tvOS" - Apple tvOS
  • "watchOS" - Apple watchOS
  • "Android" - Google Android mobile OS
  • "BSD" - BSD family (FreeBSD, NetBSD, OpenBSD)
  • "Unix" - Unix-like systems (Linux, unix-like etc.)
  • "Unknown" - Fallback for unrecognized platforms

Architecture string constants:

  • "x86_32" - 32-bit Intel x86 architecture
  • "x86_64" - 64-bit Intel x86_64 architecture
  • "arm32" - 32-bit ARM architecture
  • "arm64" - 64-bit ARM architecture
  • "unknown" - Fallback for unrecognized architectures

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-commenter
Copy link

codecov-commenter commented Oct 31, 2025

Codecov Report

❌ Patch coverage is 40.00000% with 18 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.07%. Comparing base (192ab0d) to head (364c317).

Files with missing lines Patch % Lines
source/system_info.c 40.00% 18 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1227      +/-   ##
==========================================
- Coverage   84.21%   84.07%   -0.14%     
==========================================
  Files          58       58              
  Lines        6093     6116      +23     
==========================================
+ Hits         5131     5142      +11     
- Misses        962      974      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@xiazhvera xiazhvera changed the title Add architecture string Add architecture string & Extend Apple OS Nov 3, 2025
@sbSteveK
Copy link
Contributor

sbSteveK commented Nov 5, 2025

Can we also leave a description of what this PR is doing in the top box?

@xiazhvera xiazhvera changed the title Add architecture string & Extend Apple OS Add architecture string Nov 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants