fix(aurora): aurora security group CDK native syntax #1045
+72
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aws-rafams
requested review from
krokoko,
MichaelWalker-git,
dineshSajwan and
alexa-perlov
|
I think this PR introduced a lot of unnecessary formatting changes (replaces |
|
This is weird because prime /eslint should have picked it up. |
Signed-off-by: Rafael Mosca <[email protected]>
…e-require-aurorasecuritygroupid
…e-require-aurorasecuritygroupid
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1045 +/- ##
=======================================
Coverage 94.53% 94.54%
=======================================
Files 71 71
Lines 21335 21362 +27
Branches 653 653
=======================================
+ Hits 20169 20196 +27
Misses 1166 1166 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
LGTM, just need to test it, build is green now |
moltar
approved these changes
Apr 2, 2025
…e-require-aurorasecuritygroupid
…e-require-aurorasecuritygroupid
…e-require-aurorasecuritygroupid
…e-require-aurorasecuritygroupid
…e-require-aurorasecuritygroupid
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1033
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.