fix: hard coded short-lived bedrock to regex #270
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LurkAndLoiter
force-pushed
the
fixShortLivedRegex
branch
from
24ea4fc to
01940c6
Compare
LurkAndLoiter
force-pushed
the
fixShortLivedRegex
branch
from
01940c6 to
ef4aa6a
Compare
Author
|
Apparently this is just 'bedrock.amazonaws.com' in Base64. PR271 appears to attempt to suppress the false positive this PR was originally attempting to 'fix'. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning
Unsure if intentionally hard coded.
Changes hard coded short-lived bedrock api key into a regex.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
fixes: 269