Fix stale package name references after rename to graphrag-lexical-graph (#175)#182
Open
mykola-pereyma wants to merge 2 commits intoawslabs:mainfrom
Open
Fix stale package name references after rename to graphrag-lexical-graph (#175)#182mykola-pereyma wants to merge 2 commits intoawslabs:mainfrom
mykola-pereyma wants to merge 2 commits intoawslabs:mainfrom
Conversation
version('graphrag-toolkit-lexical-graph') always raises PackageNotFoundError
since the package was renamed to graphrag-lexical-graph in v3.18.0.
This causes toolkit_version to silently default to 'unknown'/empty,
breaking user-agent tracking and retriever version reporting.
Fixes awslabs#175
The release workflow had regex steps to rewrite pip install URLs in notebooks before zipping. Since notebooks now install from PyPI (awslabs#180), these steps are dead code. Also fixes: - examples/lexical-graph/README.md: broken zip filename (missing -latest) - troubleshooting.md: old package name in uninstall command
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #175
The package was renamed from
graphrag-toolkit-lexical-graphtographrag-lexical-graphin v3.18.0, but several references were not updated.Changes
Bug fix:
version()calls use old package name (runtime impact)neptune_graph_stores.py:version('graphrag-toolkit-lexical-graph')always raisesPackageNotFoundError, causingtoolkit_versionto silently default to'unknown'and the user-agent string to report incorrect identitytraversal_based_base_retriever.py: same issue — retriever version reporting always emptyBoth now use
version('graphrag-lexical-graph').Cleanup: dead version-rewriting steps in release workflow
Fix: stale references in docs
examples/lexical-graph/README.md: download URL referencedlexical-graph-examples.zipbut the release workflow only produceslexical-graph-examples-latest.zipexamples/lexical-graph-local-dev/docs/troubleshooting.md:pip uninstallcommand used old package nameRoot cause of #175
The issue reporter observed that CloudFormation-deployed notebooks with v3.18.2 content fail while v3.17.1 works. The underlying cause: when the tag format changed from
v3.17.1tographrag-lexical-graph/v3.18.2, the release workflow's regex produced archive URLs like/refs/tags/v3.18.2.zip(404) instead of/refs/tags/graphrag-lexical-graph/v3.18.2.zip(200). This was resolved by #180 switching to PyPI installs, making the URL rewriting unnecessary. This PR removes the now-dead workflow steps and fixes the remaining stale references.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.