fix(amazon-sns-sqs-mcp-server): add tag validation to permission mutator tools - #4478
Open
hashimsharkh wants to merge 1 commit into
Open
fix(amazon-sns-sqs-mcp-server): add tag validation to permission mutator tools#4478hashimsharkh wants to merge 1 commit into
hashimsharkh wants to merge 1 commit into
Conversation
hashimsharkh
force-pushed
the
fix/permission-mutators-tag-validation
branch
from
August 11, 2026 17:55
80504bc to
5bb84c0
Compare
hashimsharkh
enabled auto-merge
August 11, 2026 17:55
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4478 +/- ##
==========================================
- Coverage 93.14% 93.14% -0.01%
==========================================
Files 1038 1038
Lines 87530 87536 +6
Branches 14121 14123 +2
==========================================
+ Hits 81529 81534 +5
Misses 3638 3638
- Partials 2363 2364 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
BenAtAmazon
previously approved these changes
Aug 12, 2026
hashimsharkh
force-pushed
the
fix/permission-mutators-tag-validation
branch
from
August 12, 2026 16:51
ce3dd91 to
43b3cac
Compare
…tor tools Three permission mutator tools (add_sns_permission, add_sqs_permission, remove_sqs_permission) bypassed the mcp_server_version tag validation that guards all other mutative operations. This allows untagged resources to be modified without the safety check. Add 'validator': is_mutative_action_allowed to the tool configuration for all three tools, consistent with other mutative operations. Also adds @BenAtAmazon to CODEOWNERS for amazon-sns-sqs-mcp-server. By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.
hashimsharkh
force-pushed
the
fix/permission-mutators-tag-validation
branch
from
August 12, 2026 17:26
fa4a007 to
1c6086c
Compare
BenAtAmazon
approved these changes
Aug 12, 2026
BenAtAmazon
approved these changes
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Three permission mutator tools (
add_sns_permission,add_sqs_permission,remove_sqs_permission) bypassed themcp_server_versiontag validation that guards all other mutative operations. This allows untagged resources to be modified without the safety check.Added
validator: is_mutative_action_allowedto the tool configuration for all three tools, consistent with other mutative operations. Also added@BenAtAmazonto CODEOWNERS.User experience
Before: Resources without the
mcp_server_versiontag could have permissions modified via these three tools, bypassing the safety gate.After: All permission mutator tools now consistently validate the tag before execution.
Checklist
Is this a breaking change? N
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.