generated from amazon-archives/__template_Custom
-
Notifications
You must be signed in to change notification settings - Fork 26
ci: migrate from macos-13 to macos-15-intel image #374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
jet-tong
wants to merge
3
commits into
main
Choose a base branch
from
workflow/upgrade-macos-github-runner-versions
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
To merge test fix first from #376, to address |
12883a6
to
fca13cf
Compare
fca13cf
to
ff21763
Compare
e484eaa
to
0e94c22
Compare
macos-13 will have Github Actions brownouts starting November 4th, and will be unsupported by December 4th. Note macos-15-intel planned to end August 2027.
Add multiprocessing_context=mp.get_context() to DataLoader calls to ensure spawn method is used instead of fork in Darwin, preventing S3 client fork handlers from corrupting AWS CRT DNS resolver threads on macOS github runners.
Use subprocess.run() instead of Popen() to mitigate race conditions in s3client fork handlers. A stronger fix might be needed if this still causes race conditions, as run() still uses fork multiprocessing.
0e94c22
to
c4a0e93
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
According to actions/runner-images#13046
This PR:
Additional context
Related items
actions/runner-images#13046
Testing
Build Wheels workflow: https://github.com/awslabs/s3-connector-for-pytorch/actions/runs/18220092432
By submitting this pull request, I confirm that my contribution is made under the terms of BSD 3-Clause License and I agree to the terms of the LICENSE.