Add new handler protocols + Codable support#351
Merged
Conversation
…s. Add closure handlers for StreamingLambdaHandler + NewLambdaHandler. Add Codable adapters.
fabianfett
reviewed
Sep 2, 2024
Collaborator
fabianfett
left a comment
There was a problem hiding this comment.
Great progress! We need docs, docs and docs. Take them from the proposal!
…mWriter`, move Foundation import from AWSLambdaRuntimeCore
Collaborator
|
API breakage check also reports on package access modifiers: |
fabianfett
reviewed
Sep 3, 2024
fabianfett
reviewed
Sep 3, 2024
fabianfett
reviewed
Sep 3, 2024
fabianfett
reviewed
Sep 3, 2024
fabianfett
reviewed
Sep 3, 2024
fabianfett
approved these changes
Sep 4, 2024
Collaborator
fabianfett
left a comment
There was a problem hiding this comment.
Looks great! Thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
As part of the implementation of the v2 API (#339), we want to add the handler protocols
LambdaHandlerandLambdaWithBackgroundProcessingHandler.Modifications:
Added the two remaining handler protocols:
LambdaHandlerandLambdaWithBackgroundProcessingHandler.LambdaHandleris currently temporarily named asNewLambdaHandleras there is already an existingLambdaHandler. This will be sorted out closer to release.Added
LambdaHandlerAdapterandLambdaCodableAdapterto allow the two new handler protocols to work with theLambdaRuntime(asLambdaRuntimerequires aStreamingLambdaHandlerconforming handler).LambdaHandlerAdapter:LambdaHandlerconforming handler to conform toLambdaWithBackgroundProcessingHandlerby passing the output returned fromLambdaHandlertoLambdaWithBackgroundProcessingHandler's output writer.LambdaCodableAdapter:LambdaWithBackgroundProcessingHandlerconforming handler to conform toStreamingLambdaHandler.ByteBufferevent intoLambdaWithBackgroundProcessingHandlers genericEventobject, and passes this to itshandle(...)function.LambdaResponseWriterinto aByteBufferand send this toStreamingLambdaHandler'sLambdaResponseStreamWriter.Added
StreamingClosureHandlerandClosureHandlerstructs conforming toStreamingLambdaHandlerandLambdaHandlerprotocols respectively.handle(...)function.Result:
LambdaHandlerandLambdaWithBackgroundProcessingHandlercan be used with the newLambdaRuntimethrough the adapters.