Skip to content

Bump unidata/tomcat-docker from 1a5fb1b to 3f8ba8c#23

Merged
kwilcox merged 1 commit into
masterfrom
dependabot/docker/unidata/tomcat-docker-3f8ba8c
Jan 20, 2021
Merged

Bump unidata/tomcat-docker from 1a5fb1b to 3f8ba8c#23
kwilcox merged 1 commit into
masterfrom
dependabot/docker/unidata/tomcat-docker-3f8ba8c

Conversation

@dependabot
Copy link
Copy Markdown
Contributor

@dependabot dependabot Bot commented on behalf of github Jan 18, 2021

Bumps unidata/tomcat-docker from 1a5fb1b to 3f8ba8c.

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps unidata/tomcat-docker from `1a5fb1b` to `3f8ba8c`.

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot added the dependencies Pull requests that update a dependency file label Jan 18, 2021
@kwilcox
Copy link
Copy Markdown
Collaborator

kwilcox commented Jan 18, 2021

@julienchastang The unidata/tomcat images changed a few days ago but I don't see any changes to https://github.com/Unidata/tomcat-docker. How can I audit the changes?

@julienchastang
Copy link
Copy Markdown

I have to regularly update that container to take into account security "Common Vulnerabilities and Exposures" (CVEs). Note that the parent container (e.g., FROM tomcat:8.5-jdk8-openjdk). Has exactly the same issue. DockerHub autobuilds based on parent container triggers may be a solution for you. Or GitHub actions which I have to familiarize myself with, as well.

@kwilcox
Copy link
Copy Markdown
Collaborator

kwilcox commented Jan 20, 2021

Thanks @julienchastang , I assumed that was the case but wanted to double check. Do you have auto-builds setup through DockerHub?

@abkfenris Implemented a nice pin-to-hash setup for this repository that creates a PR each time the base image changes, that might help you control the build process a little more if that is something you are interested in! #18 and #19.

@kwilcox kwilcox merged commit d7246bd into master Jan 20, 2021
@dependabot dependabot Bot deleted the dependabot/docker/unidata/tomcat-docker-3f8ba8c branch January 20, 2021 15:38
@abkfenris
Copy link
Copy Markdown
Collaborator

@julienchastang Here are a summary of the changes that I've done to make the docker-erddap builds more reproducible. It took a little bit to figure out the exact setup hence the multiple PRs.

@julienchastang
Copy link
Copy Markdown

I just glanced at this, but GitHub actions seems to be the right approach and one that I plan on diving into myself. Yes, currently, I rely on DockerHub for triggered builds for THREDDS and RAMADDA. Though note that I cannot trigger on the official tomcat parent container. DockerHub does not allow it (probably results in too many builds). Again, GitHub actions probably provides a solution here.

@abkfenris
Copy link
Copy Markdown
Collaborator

I can take a swing at a PR if you'd like.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants