Support caption annotation#180
Open
sarge wants to merge 2 commits into
Open
Conversation
Contributor
|
Since the tool currently doesn't generate "#EXT-X-MEDIA:TYPE=CLOSED-CAPTIONS" entries, what value would you pass with the "+captions" media source annotations? Would you pass "NONE" there? |
Author
|
Correct that is exactly how I would plan on using it. Open to suggestions, and what if anything should be the approach in mp4-dash.py |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello @barbibulle
For your consideration, a small change to signal the caption support for HLS streams. Cleans up the default Safari player offering to play captions on streams that could but do not contain captions.
Cheers
Mark