Merged
Conversation
azat
force-pushed
the
share-flamegraph
branch
3 times, most recently
from
256aebd to
22a1d46
Compare
Owner
Author
|
Egh, sometimes query may fail with |
Right now it simply upload the flamegraph into pastila.nl (directly into ClickHouse) And uses `profileURL=https://.cloud/?query=SELECT` to get the data as plain text for the https://www.speedscope.app/ I need to prepare separate service for this (I've already registered domain) to make links more pleasant. Also note, that existing speedscope links has been replaced with share via pastila.nl, but I think it is OK, for plain flamegraphs there is TUI, for everything else better to have internet connection. Also some issues pops up: - ClickHosue sipHash128 differs from standard, so it have to be re-implemented instead of using existing create - Apparently clickhouse-rs does not works with INSERT with async_insert=1, this will be fixed later Also note, that it **does not uses end-to-end encryption** (since speedscope cannot execute custom JS). Fixes: #94
azat
force-pushed
the
share-flamegraph
branch
from
22a1d46 to
f88803d
Compare
Owner
Author
|
+1MiB for linux build, can be removed with replacing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now it simply upload the flamegraph into pastila.nl (directly into ClickHouse)
And uses
profileURL=https://.cloud/?query=SELECTto get the data as plain text for the https://www.speedscope.app/I need to prepare separate service for this (I've already registered domain) to make links more pleasant.
Also note, that existing speedscope links has been replaced with share via pastila.nl, but I think it is OK, for plain flamegraphs there is TUI, for everything else better to have internet connection.
Also some issues pops up:
Also note, that it does not uses end-to-end encryption (since speedscope cannot execute custom JS).
Fixes: #94