Support controlling render modes and RendererInfo during testing #1596
Conversation
linkdotnet
force-pushed
the
net9
branch
2 times, most recently
from
7a4dd4a to
62c724c
Compare
egil
force-pushed
the
net9
branch
3 times, most recently
from
e835c6c to
948af35
Compare
egil
changed the title
|
@linkdotnet force pushed some changes! I think this is done, but there may be some improvements to the code before we merge in. |
|
Just tagging @scottsauber and @linkdotnet to see if you have suggestions to improve the code. Did some changes after the stream. Still missing a documentation page. |
| /// Gets or sets the <see cref="IComponentRenderMode"/> that will be specified in | ||
| /// the render tree for component the parameters are being passed to. | ||
| /// </summary> | ||
| public IComponentRenderMode? RenderMode { get; set; } |
There was a problem hiding this comment.
This and the ToRenderFragment method should probably have been on the builder, but that we can move in V2, where the types are internal.
| /// </summary> | ||
| /// <param name="renderMode">The render mode to assign to the component, e.g. <c>RenderMode.InteractiveServer</c>, or <see langword="null"/>, to not assign a specific render mode.</param> | ||
| /// <returns>This <see cref="ComponentParameterCollectionBuilder{TComponent}"/>.</returns> | ||
| public ComponentParameterCollectionBuilder<TComponent> SetAssignedRenderMode(IComponentRenderMode? renderMode) |
There was a problem hiding this comment.
Set still seems like the right name. Matches the SetRendererInfo on Renderer.
There was a problem hiding this comment.
Okay, yeah see comment above
| { | ||
| builder.OpenComponent<TComponent>(0); | ||
| AddAttributes(builder); | ||
| #if NET9_0_OR_GREATER |
There was a problem hiding this comment.
SetRenderMode would be better as this doesn’t have collection like behavior
linkdotnet
force-pushed
the
net9
branch
2 times, most recently
from
14cdc53 to
8588ad5
Compare
linkdotnet
force-pushed
the
net9
branch
2 times, most recently
from
6e16a75 to
9782ad9
Compare
.net 9 related changes
@rendermodeon elementtop level @rendermode