remove source link package reference not necessary

[WeihanLi]

Starting with .NET 8, Source Link for the following source control providers is included in the .NET SDK and enabled by default:

GitHub or GitHub Enterprise
Azure Repos git repositories (formerly known as Visual Studio Team Services)
GitLab 12.0+ (for older versions see GitLab settings)
Bitbucket 4.7+ (for older versions see Bitbucket settings)
If your project uses .NET SDK 8+ and is hosted by the above providers it does not need to reference any Source Link packages or set any build properties.

see https://github.com/dotnet/sourcelink?tab=readme-ov-file#using-source-link-in-net-projects

[egil]

Why is the source link package not needed?

[WeihanLi]

Why is the source link package not needed?

Starting with .NET 8, Source Link for the Github source control providers is included in the .NET SDK and enabled by default, and we're already on .NET 8 and greater sdk, so it's not a necessary

see details: https://github.com/dotnet/sourcelink?tab=readme-ov-file#using-source-link-in-net-projects

[egil]

BUnit v1 is still targeting other SDKs though. Should we not keep it in for those?

[WeihanLi]

BUnit v1 is still targeting other SDKs though

We're using multi-target frameworks, not multi SDKs, there's one effective SDK only

Let's take the AntDesign for example

There's no reference for the source link package

while from the nuget package info, it still has source link info and has pdb source info even for net5.0/netstandard2.1 dll

maybe we could pack a nuget package locally for testing

[egil]

Thanks!