Skip to content

build(deps): Bump actions/upload-artifact from 4 to 5 #1767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dependabot wants to merge 1 commit into from
Closed

build(deps): Bump actions/upload-artifact from 4 to 5 #1767

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ jobs:
dotnet pack src/bunit.generators/ -c release --output ${{ env.NUGET_DIRECTORY }} -p:ContinuousIntegrationBuild=true -p:publicrelease=true

# Publish the NuGet package as an artifact, so they can be used in the following jobs
- uses: actions/upload-artifact@v4
- uses: actions/upload-artifact@v5
with:
name: ${{ env.NUGET_PACKAGES_ARTIFACT }}
if-no-files-found: error
Expand Down Expand Up @@ -139,7 +139,7 @@ jobs:

- name: 📛 Upload hang- and crash-dumps on test failure
if: success() || failure()
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v5
with:
if-no-files-found: ignore
name: test-dumps
Copy link

Copilot AI Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The artifact name 'test-dumps' will cause conflicts when the matrix job runs across multiple OS platforms (ubuntu-latest, macos-latest, windows-latest). In upload-artifact@v5, artifact names must be unique. Include the matrix variable in the name, e.g., name: test-dumps-${{ matrix.os }}.

Suggested change
name: test-dumps
name: test-dumps-${{ matrix.os }}

Copilot uses AI. Check for mistakes.
Expand Down