Workaround for Bitnami Registry migration

[davivcgarcia]

Description of the change

Provides the fix for the recent Bitnami migration of public images to Bitnami Legacy. The usage of Bitnami Secure is risky since the only tag available is latest, and the current PostgreSQL chart uses a specific version tag.

Existing or Associated Issue(s)

Temporary Fix for #271

Additional Information

bitnami/charts#35164

Checklist

• Chart version bumped in Chart.yaml according to semver.
• Variables are documented in the values.yaml and added to the README.md. The helm-docs utility can be used to generate the necessary content. Use helm-docs --dry-run to preview the content.
• JSON Schema generated.
• List tests pass for Chart using the Chart Testing tool and the ct lint command.

[github-actions]

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

[ChrisJBurns]

@davivcgarcia Thanks for this, you'll have to bump the Helm Chart in the docs for the new version (can run pre-commit)

[github-actions]

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

[rm3l]

@ChrisJBurns Any chance we can get this merged as a temporary workaround for #271? Maybe a maintainer could run the pre-commit hooks and push the changes..
Otherwise, it looks like the chart cannot be deployed currently (see the failing test on this other PR), as the DB image could no longer be pulled:

$ kubectl get po -w                                                                                                                                                 

NAME                                      READY   STATUS              RESTARTS   AGE                                                                                          
my-upstream-backstage-1-b79b5bd64-r9n75   0/1     ContainerCreating   0          9s                                                                                           
my-upstream-backstage-1-postgresql-0      0/1     ErrImagePull        0          9s                                                                                           
my-upstream-backstage-1-postgresql-0      0/1     ImagePullBackOff    0          20s                                                                                          
my-upstream-backstage-1-postgresql-0      0/1     ErrImagePull        0          31s                                                                                          
my-upstream-backstage-1-postgresql-0      0/1     ImagePullBackOff    0          44s                                                                                          

That being said, I was thinking that we could probably automate running the pre-commit hooks on PRs, and push any resulting changes to the corresponding PR branch. Thoughts? I can file an issue and look into that later..

[davivcgarcia]

I really wanted to do it, but I didn't have time yet to understand how to execute these pre-commit hooks. Any specific doc I should take a look at?

[rm3l]

I really wanted to do it, but I didn't have time yet to understand how to execute these pre-commit hooks. Any specific doc I should take a look at?

@davivcgarcia No problem. I think you can refer to this line in the Contributing guide: https://github.com/backstage/charts/blob/main/CONTRIBUTING.md?plain=1#L7
After installing pre-commit, you could run pre-commit run --all-files from the root of the repository and commit all the resulting changes. Hope that helps.

[ChrisJBurns]

That being said, I was thinking that we could probably automate running the pre-commit hooks on PRs, and push any resulting changes to the corresponding PR branch. Thoughts? I can file an issue and look into that later..

That'd be great if you can do it, saves a bunch of manual changes.

[ChrisJBurns]

Have approved just to kick the pipeline off, you'll need to bump all of the pre-commit stuff manually I think. Also, I think we should probably release this as a breaking change, even though it may not be? This should give users more of a nudge to really double check if the new image works for them. It is a bit extreme, but better to be safe than sorry I guess

[rm3l]

Also, I think we should probably release this as a breaking change, even though it may not be? This should give users more of a nudge to really double check if the new image works for them. It is a bit extreme, but better to be safe than sorry I guess

The bitnamilegacy/postgresql images are depicted as a backup of all existing Bitnami container images, and are explicitly called out as usable for temporary migration purposes. So I'd assume that it would be a drop-in (but temporary) replacement, so backward-compatible, no?
I guess the actual breaking change would come if we decide to swap to a completely different PostgreSQL image (even with the same Postgres version), as one of the possible approaches from #271 (comment)

you'll need to bump all of the pre-commit stuff manually I think.

@davivcgarcia Did you get a chance to look into this? Let us know if you faced any issues running the pre-commit hook.. FYI, you can also see the Git diff that you need to apply from the Lint job run: https://github.com/backstage/charts/actions/runs/18469298466/job/52841520108?pr=284#step:6:135

diff --git a/charts/backstage/README.md b/charts/backstage/README.md
index ed80a5d..91bbf0d 100644
--- a/charts/backstage/README.md
+++ b/charts/backstage/README.md
@@ -2,7 +2,7 @@
 # Backstage Helm Chart
 
 [![Artifact Hub]([https://img.shields.io/endpoint?url=https://artifacthub.io/badge/repository/backstage)](https://artifacthub.io/packages/search?repo=backstage](https://img.shields.io/endpoint?url=https://artifacthub.io/badge/repository/backstage](https://artifacthub.io/packages/search?repo=backstage)))
-![Version: 2.6.1](https://img.shields.io/badge/Version-2.6.1-informational?style=flat-square)
+![Version: 2.6.2](https://img.shields.io/badge/Version-2.6.2-informational?style=flat-square)
 ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square)
 
 A Helm chart for deploying a Backstage application
@@ -201,6 +201,7 @@ Kubernetes: `>= 1.19.0-0`
 | postgresql.auth.secretKeys.userPasswordKey | The key in which Postgres will look for, for the user password, in the existing Secret | string | `"user-password"` |
 | postgresql.auth.username | Name for a custom user to create | string | `"bn_backstage"` |
 | postgresql.enabled | Switch to enable or disable the PostgreSQL helm chart | bool | `false` |
+| postgresql.image | Change default PostgreSQL image location (workaround for [https://github.com/bitnami/charts/issues/35164)](https://github.com/bitnami/charts/issues/35164)?q=sort%3Aupdated-desc+is%3Aissue+is%3Aopen) | object | `{"registry":"docker.io","repository":"bitnamilegacy/postgresql"}` |
 | service | Service parameters | object | See below |
 | service.annotations | Additional custom annotations for Backstage service | object | `{}` |
 | service.clusterIP | Backstage service Cluster IP  <br /> E.g `clusterIP: None` | string | `""` |

[davivcgarcia]

you'll need to bump all of the pre-commit stuff manually I think.

@rm3l I've synced my branch with the latest on main, and committed the changes generated by pre-commit command. Please let me know if that makes sense. Thanks for the patience. :-)

[rm3l]

you'll need to bump all of the pre-commit stuff manually I think.

@rm3l I've synced my branch with the latest on main, and committed the changes generated by pre-commit command. Please let me know if that makes sense. Thanks for the patience. :-)

Thanks. It looks good to me, unless @ChrisJBurns wants to bump the chart version to a major one to be safe.
Now up to @ChrisJBurns (or any other maintainer) to manually approve the CI workflows so GH can trigger them, I guess.

[github-actions]

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

[rm3l]

not stale

[ChrisJBurns]

Apologies for delay on this!

[ChrisJBurns]

I think the fix bump is ok, primarily because its the same image as before just a different location. I think if we ever move away to a different image/postgres subchart that's when we'll major bump