Skip to content

chore: Removing default imagePullPolicy to honor Kubernetes defaults #287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
+10 −6
Open

chore: Removing default imagePullPolicy to honor Kubernetes defaults #287

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
62c66be
Removing pullPolicy by default, so that default K8s behaviour is applied
OpinionatedHeron Oct 13, 2025
07123c5
Bumping Chart.yaml based on change - patch
OpinionatedHeron Oct 13, 2025
0e5d14a
Setting pullPolicy to empty string
OpinionatedHeron Oct 14, 2025
acf703f
Updating schema and running pre-commits
OpinionatedHeron Oct 15, 2025
a5a3f8d
Updating schema to allow all docs options
OpinionatedHeron Oct 15, 2025
dd4aec0
Merge branch 'backstage:main' into pullPolicy
OpinionatedHeron Oct 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/backstage/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,4 +38,4 @@ sources:
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 2.6.1
version: 2.6.2
4 changes: 2 additions & 2 deletions charts/backstage/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
# Backstage Helm Chart

[![Artifact Hub](https://img.shields.io/endpoint?url=https://artifacthub.io/badge/repository/backstage)](https://artifacthub.io/packages/search?repo=backstage)
![Version: 2.6.1](https://img.shields.io/badge/Version-2.6.1-informational?style=flat-square)
![Version: 2.6.2](https://img.shields.io/badge/Version-2.6.2-informational?style=flat-square)
![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square)

A Helm chart for deploying a Backstage application
Expand Down Expand Up @@ -131,7 +131,7 @@ Kubernetes: `>= 1.19.0-0`
| backstage.extraVolumes | Backstage container additional volumes | list | `[]` |
| backstage.hostAliases | Host Aliases for the pod <br /> Ref: https://kubernetes.io/docs/concepts/services-networking/add-entries-to-pod-etc-hosts-with-host-aliases/ | list | `[]` |
| backstage.image.digest | Backstage image digest (digest takes precedence over image tag) | string | `""` |
| backstage.image.pullPolicy | Specify a imagePullPolicy. Defaults to 'Always' if image tag is 'latest', else set to 'IfNotPresent' <br /> Ref: https://kubernetes.io/docs/concepts/containers/images/#image-pull-policy | string | `"Always"` |
| backstage.image.pullPolicy | Specify a imagePullPolicy. Defaults to 'Always' if image tag is 'latest', else set to 'IfNotPresent' <br /> Ref: https://kubernetes.io/docs/concepts/containers/images/#image-pull-policy | string | `""` |
| backstage.image.pullSecrets | Optionally specify an array of imagePullSecrets. Secrets must be manually created in the namespace. <br /> Ref: https://kubernetes.io/docs/tasks/configure-pod-container/pull-image-private-registry/ <br /> E.g: `pullSecrets: [myRegistryKeySecretName]` | list | `[]` |
| backstage.image.registry | Backstage image registry | string | `"ghcr.io"` |
| backstage.image.repository | Backstage image repository | string | `"backstage/backstage"` |
Expand Down
3 changes: 2 additions & 1 deletion charts/backstage/values.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4095,7 +4095,8 @@
"description": "Ref: https://kubernetes.io/docs/concepts/containers/images/#image-pull-policy",
"enum": [
"Always",
"IfNotPresent"
"IfNotPresent",
""
],
"title": "Specify a imagePullPolicy.",
"type": "string"
Expand Down
3 changes: 2 additions & 1 deletion charts/backstage/values.schema.tmpl.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,7 +258,8 @@
"default": "Always",
"enum": [
"Always",
"IfNotPresent"
"IfNotPresent",
""
]
},
"pullSecrets": {
Expand Down
2 changes: 1 addition & 1 deletion charts/backstage/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ backstage:
# -- Specify a imagePullPolicy.
# Defaults to 'Always' if image tag is 'latest', else set to 'IfNotPresent'
# <br /> Ref: https://kubernetes.io/docs/concepts/containers/images/#image-pull-policy
pullPolicy: Always
pullPolicy: ""

# -- Optionally specify an array of imagePullSecrets.
# Secrets must be manually created in the namespace.
Expand Down