GitHub Actions Extension Configuration #5883
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tent to use makeWithOverrides with a layout config item. Signed-off-by: dambrose <[email protected]>
…ions-extension-configuration Signed-off-by: dambrose <[email protected]>
Signed-off-by: dambrose <[email protected]>
Signed-off-by: dambrose <[email protected]>
…n-configuration' into dambrose/github-actions-extension-configuration Signed-off-by: dambrose <[email protected]> # Conflicts: # workspaces/github-actions/.changeset/nine-jars-travel.md
Signed-off-by: dambrose <[email protected]>
…ated test environment. Added a test case for the content card layout variant. Updated test cases to include null cases for the opposite layout to what's being tested. Signed-off-by: dambrose <[email protected]>
Changed Packages
|
Rugvip
reviewed
Oct 20, 2025
workspaces/github-actions/plugins/github-actions/src/alpha/entityContent.test.tsx
Outdated
Show resolved
Hide resolved
Comment on lines
-55
to
-57
| await waitFor( | ||
| () => { | ||
| expect(screen.getByText('backstage/backstage')).toBeInTheDocument(); |
There was a problem hiding this comment.
Noting for readers that this test didn't behave as expected, it hid an issue where routing didn't work and the page blew up after initial render.
Signed-off-by: dambrose <[email protected]>
Co-authored-by: Patrik Oldsberg <[email protected]> Signed-off-by: Dan Ambrose <[email protected]>
Rugvip
reviewed
Oct 21, 2025
| layout: z => z.enum(['table', 'cards']).default('table'), | ||
| }, | ||
| }, | ||
| name: 'github-actions-entity-content', |
There was a problem hiding this comment.
Oh, I realized this name should go away. The previous 'entity' doesn't really make sense either tbh and I think it's worth shipping a breaking change, especially since we're adding config with this.
The default full ID for this extension without a name is entity-content:github-actions. If we set the name to this the full name is gonna be entity-content:github-actions/github-actions-entity-content 😅
Signed-off-by: dambrose <[email protected]>
…n-configuration' into dambrose/github-actions-extension-configuration Signed-off-by: dambrose <[email protected]>
Signed-off-by: dambrose <[email protected]>
Signed-off-by: dambrose <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, I just made a Pull Request!
Follow up task to #5678,
EntityContentBlueprintto allow it to switch betweentableandcardsview.compatWrapperto the factory loader, and route refs to the tests.cardlayout.✔️ Checklist
Signed-off-byline in the message. (more info)