Use more of C++11 and later features #31
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Default the destructor and migrate typedef to using declaration Delete move constructor and move assignment operator as well.
…mark it as default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Pull Request Guidelines
Not fixing an existing PR
This Pull-Request Fixes the Following Issue(s)
No specific issue that it fixes but is cleaner and will give better compiler error messages in the cases of copy construction and move operator usage.
Proposed Changes
Use more of C++11 and later features to give the compiler the ability to better optimize.
Testing Procedure
How do we test it?
This should all be transparent to the end user. But for the sake of completeness, the examples should still compile and work as intended.