ProtocolFeeSweeper: use fee recipient as admin
#1315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 21, 2025 10:32
- Add tests - Refactor common auth to vault
jubeira
requested review from
EndymionJkb,
elshan-eth and
joaobrunoah
and removed request for
EndymionJkb
elshan-eth
approved these changes
Feb 21, 2025
EndymionJkb
approved these changes
Feb 21, 2025
| @@ -114,4 +107,28 @@ contract PoolMock is IBasePool, IPoolLiquidity, BalancerPoolToken, BasePoolAuthe | |||
| function getRate() public view override returns (uint256) { | |||
| return _mockRate == 0 ? super.getRate() : _mockRate; | |||
| } | |||
|
|
|||
| function getTokenInfo() | |||
There was a problem hiding this comment.
Why not keep the PoolInfo base contract, which already defines getTokenInfo and getAggregateFeePercentages the same way?
Not sure why it had BasePoolAuthentication; seems fine to remove that, as there are no permissioned functions at this level.
There was a problem hiding this comment.
because it makes the vault package implicitly depend on pool-utils, whereas actually it's the other way around.
It didn't cause issues here, but BasePoolAuthentication was throwing a very confusing one; this should prevent that from happening.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR:
Type of change
Checklist:
main, or there's a description of how to mergeIssue Resolution
N/A