ProtocolFeeController v2 (working migration edition)

[EndymionJkb]

Description

So... turns out the original plan for two migration scripts (a first simple and a later more comprehensive one) doesn't actually work. We need the full migration even for the first time; the "update" functions must be called by the current fee controller, so can't be used during a migration.

It's actually simpler this way, as there's only one migration script now. The only catch is we have to tolerate the pool creator fee getters failing the first time, as they don't exist in the original fee controller. This is fine the first time, as there are no overrides or pool creators (both of which can be recreated in the new fee controller using permissioned calls from governance and the pool creators respectively, in case we miss one).

For the second and all subsequent migrations, they will work and copy the entire state.

Type of change

• Bug fix
• New feature
• Breaking change
• Dependency changes
• Code refactor / cleanup
• Optimization: [ ] gas / [ ] bytecode
• Documentation or wording changes
• Other

Checklist:

• The diff is legible and has no extraneous changes
• Complex code has been commented, including external interfaces
• Tests have 100% code coverage
• The base branch is either main, or there's a description of how to merge

Issue Resolution