Validate target OS update version is not same as current#381
Draft
Validate target OS update version is not same as current#381
Conversation
Change-type: patch Signed-off-by: Ken Bannister <kb2ma@runbox.com>
kb2ma
force-pushed
the
os_version_must_advance
branch
from
255b288 to
4838771
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The balena-hup-action-utils package validates this condition for the Node SDK. The Python SDK must do the same. The docs say it does. ;-)
This PR is a WIP. Need to resolve how build versions compare. Presently test fails for x.y.z+rev1 vs. x.y.z+rev2 -- they compare as equal.