Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use a dynamic sampler to speed-up weighted sampling #30
Use a dynamic sampler to speed-up weighted sampling #30
Changes from 43 commits
be5eeec
97256dd
02aac7d
6a93a32
f690dd6
8911483
a39c7e9
796b6ad
b3a30cb
b563c6a
d77356b
8ade0a5
bdbe79e
87c9d0f
edb40ce
5e9893d
a141332
addeb6e
3e9cd66
1ad4ae0
85ec846
6e6b164
9aab5ad
c77a01d
1649feb
5c9d9b8
007b9bc
a433a9f
3e63fc8
194b35c
1b7c804
4b96c41
59c541c
9d89a38
54b5e74
05d59d7
7242859
5c624dc
02e049e
a0616aa
54dc4ba
05112ee
939c65a
26811d2
96ab651
5e13bc1
8d1c150
f434e62
24d77e5
b9c0d95
2f905f7
f3fc684
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, this PR is based on the use of this package. Would you have a paper that describes the technique implemented there?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I think you can find some references of the technique of the package in
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will add something to the package explaining the origin of the technique
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you explain what
@~
does?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@~
comes fromLazyArrays.jl
and allows us to "wait" until that operations are actually required to run, we can then fuse the operations, so that we don't need more passes over data