Skip to content

[Fix] tss signature is missing#88

Merged
RogerKSI merged 3 commits into
mainfrom
fix-tss-failed
May 15, 2026
Merged

[Fix] tss signature is missing#88
RogerKSI merged 3 commits into
mainfrom
fix-tss-failed

Conversation

@Marca23

@Marca23 Marca23 commented May 13, 2026

Copy link
Copy Markdown
Contributor

Fixed: prevent relayer panics when TSS signing or packet data is missing

Implementation details

  • Alert when TSS is missing
  • Skip packets with missing TSS for all non-EVM chains

Please ensure the following requirements are met before submitting a pull request:

  • The pull request is targeted against the correct target branch
  • The pull request is linked to an issue with appropriate discussion and an accepted design OR is linked to a spec that describes the work.
  • The pull request includes a description of the implementation/work done in detail.
  • The pull request includes any and all appropriate unit/integration tests
  • You have added a relevant changelog entry to CHANGELOG_UNRELEASED.md
  • You have re-reviewed the files affected by the pull request (e.g. using the Files changed tab in the Github PR explorer)

@Marca23
Marca23 requested a review from RogerKSI May 13, 2026 08:39
@Marca23 Marca23 self-assigned this May 13, 2026
@RogerKSI
RogerKSI requested a review from Copilot May 13, 2026 10:12

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR hardens TunnelRelayer.getTunnelPacket against panics/loops caused by missing TSS signing data. Previously, falling back from CurrentGroupSigning to IncomingGroupSigning could overwrite a usable signing with nil, and a not-success status on a non-EVM chain would cause the same sequence to be retried indefinitely.

Changes:

  • Only swap signing to IncomingGroupSigning when the incoming value is non-nil.
  • Emit an alert and return an error when no signing info is available at all.
  • On a non-success signing status, advance lastRelayedSequence/lastRelayedAt for non-EVM chains so the packet is skipped on subsequent rounds.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread relayer/tunnel_relayer.go
Comment thread relayer/tunnel_relayer.go
Comment thread relayer/tunnel_relayer.go Outdated
Comment thread relayer/tunnel_relayer.go
Comment thread relayer/tunnel_relayer.go Outdated
@RogerKSI
RogerKSI merged commit eb211dd into main May 15, 2026
2 checks passed
@RogerKSI
RogerKSI deleted the fix-tss-failed branch May 15, 2026 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants