Nicer error handling when there is no content #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
204 No Content is indicating success https://developer.mozilla.org/en-US/docs/Web/HTTP/Status/204 The same check already happend in the error callback but that one does not seem to get hit. Now the error also contains the url that was expected to return content. So the user knows where to start debugging. I am currently getting back no content half of the time for this url https://sessionserver.mojang.com/session/minecraft/hasJoined?username=xxx&serverId=xxx&ip=127.0.0.1 and then it crashes with the following error: ``` Traceback (most recent call last): File "/home/chiller/Desktop/git/2bored2wait-quarry/venv/lib/python3.10/site-packages/twisted/internet/defer.py", line 1078, in _runCallbacks current.result = callback( # type: ignore[misc] File "/home/chiller/Desktop/git/quarry/quarry/net/http.py", line 49, in _callback2 d0.callback(None) File "/home/chiller/Desktop/git/2bored2wait-quarry/venv/lib/python3.10/site-packages/twisted/internet/defer.py", line 877, in callback self._startRunCallbacks(result) File "/home/chiller/Desktop/git/2bored2wait-quarry/venv/lib/python3.10/site-packages/twisted/internet/defer.py", line 984, in _startRunCallbacks self._runCallbacks() --- <exception caught here> --- File "/home/chiller/Desktop/git/2bored2wait-quarry/venv/lib/python3.10/site-packages/twisted/internet/defer.py", line 1078, in _runCallbacks current.result = callback( # type: ignore[misc] File "/home/chiller/Desktop/git/quarry/quarry/net/server.py", line 128, in auth_ok self.uuid = UUID.from_hex(data['id']) builtins.TypeError: 'NoneType' object is not subscriptable ``` Now it prints the following helpful error message: ``` Auth failed: No Content: No content was returned by the server for the url b'https://sessionserver.mojang.com/session/minecraft/hasJoined?username=xxx&serverId=xxx&ip=127.0.0.1 ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
204 No Content is indicating success
https://developer.mozilla.org/en-US/docs/Web/HTTP/Status/204
The same check already happend in the error callback but that one does not seem to get hit.
Now the error also contains the url that was expected to return content. So the user knows where to start debugging.
I am currently getting back no content half of the time for this url https://sessionserver.mojang.com/session/minecraft/hasJoined?username=xxx&serverId=xxx&ip=127.0.0.1
and then it crashes with the following error:
Now it prints the following helpful error message:
Before
Using the proxy chat example with online auth patched in it would occasionally break for me.
Then it crashes on NoneType in the log and the vanilla minecraft client gets stuck in the "Encrypting..." screen.
After
Now it shows a clear error what went wrong it the log without crashing. And the end user also sees the information.