Skip to content

Respect CastAttributes::castUsing generic types #1701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Watercycle
Copy link

Summary

See #1700

This PR adds some logic for parsing generic types from CastAttributes::castUsing doc-blocks to allow for specializing castUsing while casting Laravel model columns.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Misc. change (internal, infrastructure, maintenance, etc.)

Checklist

  • Existing tests have been adapted and/or new tests have been added
  • Update the README.md
  • Code style has been fixed via composer fix-style

@Watercycle
Copy link
Author

Watercycle commented Apr 15, 2025

As a general disclaimer: This probably doesn't work with templated generic types (e.g. @template TGet) and does not solve this related issue: #1437. If you have a more generic solution in mind or see this as fundamentally flawed, please let me know and I'll take another pass at this!

@Watercycle Watercycle changed the title Respect Specialized CastAttributes Child Types Respect CastAttributes::castUsing Generic Types Apr 15, 2025
@Watercycle Watercycle changed the title Respect CastAttributes::castUsing Generic Types Respect CastAttributes::castUsing Generic types Apr 15, 2025
@Watercycle Watercycle changed the title Respect CastAttributes::castUsing Generic types Respect CastAttributes::castUsing generic types Apr 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant