feat: add extraction of enums from markers #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: add extraction of enums from markers
QuCMGisaia
force-pushed
the
feature/enumExtract
branch
from
5a602c7 to
966cb23
Compare
bastianjoel
pushed a commit
to bastianjoel/ngx-translate-extract
that referenced
this pull request
Sep 15, 2023
* fix(pipe-parser) search for pipe in structural directives
* refactor(pipe-parser) simplify handling of pipes in getTranslatablesFromAst
remove expressionIsOrHasBindingPipe - previously this also handled cases like `'World' | translate | upper`,
but it's not actually needed, getTranslatablesFromAst can deal with it by itself
move checks for translate and non-translate pipes together under a common BindingPipe check.
* fix(pipe-parser): find usages of translate pipe in arguments of other pipes
* feat(pipe): accommodate marker directive
* feat(pipe): accommodate forks of marker fn
* feat(pipe): accommodate marker pipe
* chore: initial commit after fork
* fix: fixed some botched imports
* chore: editorconfig, refactoring and bump
* chore: fixed some botched imports
* re-add --marker option
-m or --marker is an old option that was in
biesbjerg/ngx-translate-extract
it was removed and replaced by the ngx-extract-translate-marker
mechanism but this new mechanism does not allow to easily
customize what the marker function does
(some users have use cases where this is not a no-op)
* Create node.js.yml
* chore: update changelog, readme and bump version
* chore: busywork in prep for the lib to move back into vendure's fork
---------
Co-authored-by: P4 <[email protected]>
Co-authored-by: Christer Olsen <[email protected]>
Co-authored-by: Thomas Mijieux <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello !
This PR aims to allow for the marker extraction to also extract enum members to improve i18n files generation.
Removes the limitation that was in place on the query of
CallExpressionto allowPropertyAccessExpression. This allows to get markers with Enum. By testing the structure of theExpression, we gather the information relative to the enum member that we are looking for. By browsing the files that contain the enumeration (whether locally or in the imports of the file), we can find the value that the enum member was initialized to. If the value is of typestringwe keep it in the extracted list.