fix(fork-runner): reconcile feature state idempotently (coordinate with base-anvil #39)#168
Merged
Merged
Conversation
The runner unconditionally called activate(), which reverts AlreadyActivated once base-anvil seeds features active in a fresh anvil --base node (BOP-375, base-anvil#39). Check isActivated() first: ensure non-skipped features active and SKIP_ACTIVATE features inactive (via deactivate). Works whether the node boots features inactive or seeded active, so base-anvil#39 lands without breaking make fork-tests.
amiecorso
requested review from
eric-ships,
ilikesymmetry,
rayyan224 and
stevieraykatz
as code owners
Interface Coverage✅ All interface functions have test coverage. |
📊 Forge Coverage (
|
| File | Lines | Stmts | Branches | Funcs |
|---|---|---|---|---|
| 🟢 B20FactoryLib.sol | 100.00% | 100.00% | 100.00% | 100.00% |
| 🔴 test/lib/ForceFeeder.sol | 0.00% | 0.00% | 100.00% | 0.00% |
| 🔴 test/lib/PrecompileProbe.sol | 0.00% | 0.00% | 0.00% | 0.00% |
| 🟢 MockActivationRegistry.sol | 100.00% | 100.00% | 100.00% | 100.00% |
| 🟢 MockActivationRegistryStorage.sol | 100.00% | 100.00% | 100.00% | 100.00% |
| 🟢 MockB20.sol | 100.00% | 100.00% | 100.00% | 100.00% |
| 🟢 MockB20Asset.sol | 100.00% | 100.00% | 100.00% | 100.00% |
| 🟡 MockB20Factory.sol | 98.96% | 99.10% | 100.00% | 100.00% |
| 🟢 MockB20Stablecoin.sol | 100.00% | 100.00% | 100.00% | 100.00% |
| 🟢 MockB20Storage.sol | 100.00% | 100.00% | 100.00% | 100.00% |
| 🟢 MockPolicyRegistry.sol | 100.00% | 100.00% | 100.00% | 100.00% |
| 🟢 MockPolicyRegistryStorage.sol | 100.00% | 100.00% | 100.00% | 100.00% |
| Total | 96.69% | 97.23% | 98.39% | 96.89% |
Full report: download artifact. To browse locally: make coverage (runs forge coverage + genhtml + opens the HTML report).
✅ Fork tests: all 616 passedbase/base is fully in sync with the base-std spec. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Standalone, code-only change (no dependency on #167).
What
script/fork/__main__.pyreconciles each gated feature to the state a run needs instead of unconditionally callingactivate(): it checksisActivated()first, ensures non-skipped features active, and deactivatesSKIP_ACTIVATEfeatures.Why
activate()revertsAlreadyActivatedonce base-anvil seeds the gated features active in a freshanvil --basenode (base-anvil#39 / BOP-375). The current unconditional-activate runner would then failmake fork-tests(and base-std fork CI) with "activation tx reverted." This makes the runner idempotent so it works whether the node boots features inactive (today) or seeded active (after #39).Order
Merge this before base-anvil#39 so fork testing survives the node auto-seed. Independent of #167 (auto-detect + docs).
Test plan
python -m py_compileclean. Behavior is unchanged against a current (inactive-seed) node: non-skipped features get activated, SKIP_ACTIVATE features stay inactive.