feat(CHAIN-3398): support optional wssUrl in Solana adapter config#67
Merged
feat(CHAIN-3398): support optional wssUrl in Solana adapter config#67
Conversation
Allow callers to provide an explicit WebSocket URL for RPC subscriptions instead of always deriving it from the HTTP rpcUrl. This is needed for providers that expose different endpoints for HTTP and WebSocket connections. - Add optional wssUrl to SolanaAdapterConfig / SolanaChainAdapter - Add validateWssUrl (ws:/wss: scheme check) and refactor validateRpcUrl to share a common validateUrlScheme helper - Propagate wssUrl through route adapters into SolanaEngine - Add comprehensive unit tests for the new validation and config
jackchuma
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
wssUrlfield toSolanaAdapterConfigandSolanaChainAdapter, allowing callers to specify a dedicated WebSocket endpoint for RPC subscriptions instead of always deriving one from the HTTPrpcUrl. This is needed for providers that expose separate HTTP and WebSocket endpoints.validateRpcUrlinto a sharedvalidateUrlSchemehelper and introducesvalidateWssUrl(acceptsws:/wss:schemes).wssUrlthroughBaseToSvmRouteAdapter,SvmToBaseRouteAdapter, andSolanaEngine.validateWssUrlandmakeSolanaAdapterwssUrl handling.