Add Fault Proof upgrade template directory #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Heimdall Review Status
|
cbfyi
reviewed
Feb 19, 2025
cbfyi
reviewed
Feb 19, 2025
setup-templates/template-hardfork/script/DeployDisputeGames.s.sol
Outdated
Show resolved
Hide resolved
cbfyi
previously approved these changes
Feb 19, 2025
cb-heimdall
dismissed
cbfyi’s stale review
Approved review 2626547191 from cbfyi is now dismissed due to new commit. Re-request for approval.
cbfyi
approved these changes
Feb 19, 2025
xenoliss
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a template directory for a common pattern we will see moving forward - needing to upgrade our fault proof system to use new
FaultDisputeGameandPermissionedDisputeGamecontracts referencing an updated absolute prestate. The directory is set up to work for mainnet out of the box but would require some slight modifications for testnet as detailed in the README file.