Skip to content

[Sepolia] set up sepolia owner migration to mirror mainnet hierarchy #288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 20, 2025
Merged

[Sepolia] set up sepolia owner migration to mirror mainnet hierarchy #288

merged 2 commits into from
Mar 20, 2025

Conversation

jackchuma
Copy link
Contributor

No description provided.

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Mar 15, 2025 •
edited
Loading

✅ Heimdall Review Status

Requirement Status More Info
Reviews ✅ 2/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@cb-heimdall
Copy link
Collaborator

Review Error for xenoliss @ 2025-03-17 09:52:54 UTC
User failed mfa authentication, see go/mfa-help

xenoliss
xenoliss previously approved these changes Mar 17, 2025
View reviewed changes
@jackchuma jackchuma requested a review from mdehoog March 17, 2025 15:32
mdehoog
mdehoog previously approved these changes Mar 17, 2025
View reviewed changes
Copy link
Contributor

@mdehoog mdehoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice 🙌

@cb-heimdall cb-heimdall dismissed stale reviews from xenoliss and mdehoog March 19, 2025 21:15

Approved review 2689801926 from xenoliss is now dismissed due to new commit. Re-request for approval.

@cb-heimdall
Copy link
Collaborator

Review Error for awilliams1-cb @ 2025-03-19 23:10:55 UTC
User must have write permissions to review

@jackchuma jackchuma requested review from mdehoog and xenoliss March 19, 2025 23:14
@jackchuma jackchuma merged commit d3774bb into main Mar 20, 2025
3 checks passed
@jackchuma jackchuma deleted the jack/mirror-mainnet-hierarchy branch March 20, 2025 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdehoog mdehoog mdehoog approved these changes

@xenoliss xenoliss xenoliss approved these changes

@awilliams1-cb awilliams1-cb awilliams1-cb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jackchuma @cb-heimdall @mdehoog @xenoliss @awilliams1-cb