Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: upgrade fault proof template #299

Merged
merged 1 commit into from
Apr 3, 2025
Merged

fix: upgrade fault proof template #299

merged 1 commit into from
Apr 3, 2025

Conversation

jackchuma
Copy link
Contributor

Fixes absolute prestate handling in the template for fault proof upgrades and adds more robust postchecks after dispute game deployments

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Mar 27, 2025 •
edited
Loading

✅ Heimdall Review Status

Requirement Status More Info
Reviews ✅ 2/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@jackchuma jackchuma requested review from cbfyi and mdehoog April 3, 2025 18:16
@jackchuma jackchuma merged commit b34c233 into main Apr 3, 2025
3 checks passed
@jackchuma jackchuma deleted the jack/fix-upgrade-fault-proof-template branch April 3, 2025 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xenoliss xenoliss xenoliss approved these changes

@cbfyi cbfyi cbfyi approved these changes

@mdehoog mdehoog Awaiting requested review from mdehoog

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jackchuma @cb-heimdall @xenoliss @cbfyi