Simplify nested ownership transfer #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Heimdall Review Status
|
henridevieux
previously approved these changes
Apr 2, 2025
xenoliss
reviewed
Apr 3, 2025
|
|
||
| # 7-of-10 | ||
| NESTED_SIGNER_TO_ADD= | ||
| SAFE_B_OWNERS_ENCODED= |
There was a problem hiding this comment.
I'm not strongly opposed to this because abi encoded addresses are quite readable but I think it's important to keep the .env human readable.
xenoliss
previously approved these changes
Apr 3, 2025
cb-heimdall
dismissed stale reviews from henridevieux and xenoliss
Approved review 2736240471 from henridevieux is now dismissed due to new commit. Re-request for approval.
|
Review Error for xenoliss @ 2025-04-03 09:08:17 UTC |
xenoliss
reviewed
Apr 3, 2025
|
|
||
| // Adds `SAFE_A` and `SAFE_B` as owners to `OWNER_SAFE` and sets threshold to 2 | ||
| // `SAFE_A` should have same owners as `OWNER_SAFE` | ||
| // `SAFE_A` should have same threshold as `OWNER_SAFE` |
There was a problem hiding this comment.
Is there any reason we do not mention that SAFE_A should be 3o6 (or more generally even that SAFE_A must have the exact same config as OWNER_SAFE)?
cbfyi
reviewed
Apr 3, 2025
| ## | ||
| .PHONY: deploy | ||
| deploy: | ||
| forge script --rpc-url $(L1_RPC_URL) DeploySafes --account testnet-admin --broadcast -vvvv |
cbfyi
approved these changes
Apr 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.