Skip to content

[CHAIN-1516/MAINNET] System config upgrade #350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

[CHAIN-1516/MAINNET] System config upgrade #350

wants to merge 8 commits into from

Conversation

xenoliss
Copy link
Contributor

@xenoliss xenoliss commented Jun 4, 2025

No description provided.

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Jun 4, 2025 •
edited
Loading

✅ Heimdall Review Status

Requirement Status More Info
Reviews ✅ 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@xenoliss xenoliss force-pushed the bo/system-config-upgrade-mainnet branch from 008f4cb to 1b4c117 Compare June 5, 2025 07:24
jackchuma
jackchuma reviewed Jun 5, 2025
View reviewed changes
Copy link
Contributor

@jackchuma jackchuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noting that we'll likely need to update the validation files after running the deployment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roger-bai-coinbase roger-bai-coinbase roger-bai-coinbase left review comments

@jackchuma jackchuma jackchuma approved these changes

@mdehoog mdehoog Awaiting requested review from mdehoog

@henridevieux henridevieux Awaiting requested review from henridevieux

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xenoliss @cb-heimdall @jackchuma @roger-bai-coinbase