This repository was archived by the owner on Sep 9, 2025. It is now read-only.
chore(contracts): store the master chain block timestamp when syncing#1
Merged
chore(contracts): store the master chain block timestamp when syncing#1
Conversation
niran
approved these changes
Dec 6, 2024
| PartialOutputRootPreimages partialOutputRootPreimages; | ||
| /// @dev The master L2 block header, encoded in RLP format. | ||
| /// NOTE: Its hash is computed to complete the `partialOutputRootPreimages`. | ||
| bytes masterL2BlockHeaderRlp; |
Collaborator
There was a problem hiding this comment.
It might be worth moving this into the OutputRootPreimages struct so it's not "partial" anymore and doesn't need so much explanation. I think it's easier to explain that the header needs to be hashed first.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switch from using the L1 block timestamp to using the master (L2) block timestamp when syncing the Keystore config.
Also rolls back the OutputRoot prefix&suffix pattern for now, but we might re-add the suffix part in the future.