Skip to content

test: cover trailing cert bytes cache poisoning guard #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
leanthebean wants to merge 1 commit into
base: main
Choose a base branch
from
+23 −0
Open

test: cover trailing cert bytes cache poisoning guard #38

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions test/hinted/HintedNitroAttestation.t.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -478,6 +478,29 @@ contract HintedNitroAttestationTest is Test {
certManager.verifyCACertWithHints(abi.encodePacked(caCert, bytes1(0x00)), parentHash, "");
}

function test_HintedTrailingRootBytesCannotPoisonParentCache() public {
bytes memory attestation = _repairMissingPublicKeyBytes(_decodeBase64(_realAttestationB64()));
(bytes memory attestationTbs,) = validator.decodeAttestationTbs(attestation);
NitroValidator.Ptrs memory ptrs = parser.parseAttestation(attestationTbs);

bytes memory rootCert = attestationTbs.slice(ptrs.cabundle[0]);
bytes memory caCert = attestationTbs.slice(ptrs.cabundle[1]);
bytes32 rootHash = keccak256(rootCert);
assertEq(rootHash, certManager.ROOT_CA_CERT_HASH(), "expected pinned AWS Nitro root");

bytes memory shadowRoot = abi.encodePacked(rootCert, bytes1(0x00));
bytes32 shadowRootHash = keccak256(shadowRoot);
bytes memory shadowRootHints =
hintCollector.collectCertSignatureHints(shadowRoot, certManager.loadVerified(rootHash).pubKey);

vm.expectRevert("invalid cert length");
certManager.verifyCACertWithHints(shadowRoot, rootHash, shadowRootHints);
assertEq(certManager.loadVerified(shadowRootHash).pubKey.length, 0, "shadow root must not cache");

vm.expectRevert("parent cert unverified");
certManager.verifyCACertWithHints(caCert, shadowRootHash, "");
}

function test_HintedCACertRejectsTrailingFieldInsideCertificateSequence() public {
bytes memory attestation = _repairMissingPublicKeyBytes(_decodeBase64(_realAttestationB64()));
(bytes memory attestationTbs,) = validator.decodeAttestationTbs(attestation);
Expand Down
Loading