fix: normalize ASN.1 BIT STRING key usage bits#39
Open
leanthebean wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cb302161-be6b-49b6-bb87-c0d5cc3d5d60.decipherOnlymust not aliasdigitalSignature, andkeyCertSign | decipherOnlymust still satisfy the CA keyCertSign mask.Security
CertManager._verifyKeyUsageExtensionintentionally checks X.509 KeyUsage bits with0x80fordigitalSignatureand0x04forkeyCertSign. Before this change,Asn1Decode.bitstringUintAtreturned multi-byte BIT STRING payloads as a big-endian integer, so those masks targeted the last content octet when the KeyUsage BIT STRING had more than one payload byte.This change keeps the first KeyUsage payload octet in the least significant byte, preserving the existing masks for both one-byte and multi-byte KeyUsage encodings. It also enforces DER-style unused-bit padding, so malformed trailing padding cannot influence the decoded value.
Tests
forge test --match-path test/Asn1Decode.t.sol -vvvforge test