fix: bound attestation CBOR container counts#40
Open
leanthebean wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
58c1f4c1-1da4-4fd1-94c6-6c021b57e0a3.pcrsandcabundlecounts before allocatingCborElement[].MAX_PCRS = 32for the existing PCR validation limit and addMAX_CABUNDLE_CERTS = 32, which is well above the current AWS Nitro 4-cert bundle.cabundlepayload and the sibling large-countpcrspayload.Security
validateAttestationWithHintsparsesattestationTbsbefore certificate and signature verification. Before this change, a caller could set a huge definite CBOR count forcabundleorpcrs, forcingnew CborElement[](count)to trigger quadratic memory expansion and OOG before authentication.This change rejects excessive counts before allocation, so hostile pre-auth payloads fail with explicit bounded reverts instead of consuming the call gas limit.
Tests
forge test --match-test 'test_neg_large.*Count_revertsBeforeAllocation' -vvvforge test