Make ImageWithLoading lazy by default #2728
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Images now lazy-load and decode async by default in ImageWithLoading. You can still override; we skip loading when priority is true. No UI changes.
|
@Snowmanzx is attempting to deploy a commit to the Coinbase Team on Vercel. A member of the Team first needs to authorize it. |
Collaborator
🟡 Heimdall Review Status
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
Set default loading="lazy" and decoding="async" in ImageWithLoading. Added optional loading/decoding/priority props and forwarded them to ImageAdaptive; omit loading when priority is true to avoid Next.js warnings. Goal: safe perf hints without changing UI.
Notes to reviewers
Scope is limited to ImageWithLoading (and pass-through in ImageAdaptive if needed). Please verify hero images use priority and that no Next.js warning appears about priority together with loading.
How has it been tested?
Not tested locally. Relying on CI checks and a quick visual review in the preview.