feat(BA-2964): Premium price UI with fixes #2767
Draft
+535
−1,075
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
We missed two things in #2691
nameExpirescan be0nfor names that aren't registered. This is falsy and incorrectly tripped up the error catching logic for!result.This pr addresses both issues and moves the error logging out of the hook by returning the loading and error states from the hook. Consumers now check for loading and error states and act accordingly.
Notes to reviewers
How has it been tested?
Have you tested the following pages?
BaseWeb