Skip to content

Conversation

@stevieraykatz
Copy link
Contributor

@stevieraykatz stevieraykatz commented Nov 6, 2025

What changed? Why?

We missed two things in #2691

  1. The return value from nameExpires can be 0n for names that aren't registered. This is falsy and incorrectly tripped up the error catching logic for !result.
  2. The contract read loading state wasn't properly handled leading to async failures where isLoading was true and therefore causing the same error catching on result to correctly throw for a falsy value.

This pr addresses both issues and moves the error logging out of the hook by returning the loading and error states from the hook. Consumers now check for loading and error states and act accordingly.

Notes to reviewers

How has it been tested?

Have you tested the following pages?

BaseWeb

  • [] base.org
  • [] base.org/names
  • [] base.org/builders
  • [] base.org/ecosystem
  • [] base.org/name/jesse
  • [] base.org/manage-names
  • [] base.org/resources

@linear
Copy link

linear bot commented Nov 6, 2025

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Nov 6, 2025

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@vercel
Copy link

vercel bot commented Nov 6, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
base-web Ready Ready Preview Comment Nov 6, 2025 0:40am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants