Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update yarn release and rc file to match package.json spec #558

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

JFrankfurt
Copy link
Contributor

@JFrankfurt JFrankfurt commented Jun 13, 2024

What changed? Why?
noticed that the yarn release we've got here doesn't match the specified version in package.json, so updating it.

3.2.4->3.5.0

This appears to fix a bug related to corepack and a missing yarn URL import.

Notes to reviewers
see current package.json: https://github.com/base-org/web/blob/master/package.json#L70C1-L71C1

How has it been tested?
everything functions as usual locally

@JFrankfurt JFrankfurt requested a review from zencephalon June 13, 2024 14:46
Copy link

vercel bot commented Jun 13, 2024

@JFrankfurt is attempting to deploy a commit to the Coinbase Team on Vercel.

A member of the Team first needs to authorize it.

@JFrankfurt JFrankfurt changed the title update yarn release and rc file to match package.json spec chore: update yarn release and rc file to match package.json spec Jun 13, 2024
@JFrankfurt JFrankfurt requested a review from brendan-defi June 13, 2024 14:53
@JFrankfurt JFrankfurt self-assigned this Jun 13, 2024
Copy link
Collaborator

@zencephalon zencephalon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, looks like the build fails

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Jun 13, 2024

🟡 Heimdall Review Status

Item Status More Info
Minimum Required Reviews 🟡 0/1
Show calculation
Show calculations
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculations
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

📝 Heimdall docs · 🕵️ Advanced details · ♻️ Refresh Heimdall · #️⃣ #ask-heimdall

@cb-heimdall
Copy link
Collaborator

Review Error for zencephalon @ 2024-06-13 15:11:03 UTC
User failed mfa authentication, see go/mfa-help

@JFrankfurt JFrankfurt marked this pull request as draft June 13, 2024 15:34
@JFrankfurt JFrankfurt requested a review from zencephalon June 13, 2024 15:57
@JFrankfurt JFrankfurt marked this pull request as ready for review June 13, 2024 15:57
@JFrankfurt
Copy link
Contributor Author

@zencephalon thanks, had to run the new yarn cli to update a few checksums

run updated yarn version to patch checksums
@zencephalon zencephalon merged commit 699c798 into base:master Jun 18, 2024
3 of 4 checks passed
JFrankfurt added a commit that referenced this pull request Jun 18, 2024
kirkas pushed a commit that referenced this pull request Oct 21, 2024
run updated yarn version to patch checksums
chrischang pushed a commit to chrischang/web that referenced this pull request Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants