Skip to content

Updated Zellij themes with new specs #451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 18, 2025
Merged

Conversation

Kasui92
Copy link
Contributor

@Kasui92 Kasui92 commented May 8, 2025

This update is based on this issue which reports that text highlighting with the mouse no longer appears in the terminal.

Checking the Zellij documentation they changed the specs for the themes and those in the previous format are considered legacy although they are still supported.

I then proceeded with the alignment and then provided a migration script.

I found all the themes in the Zellij repository, instead for rose-pine I relied on this repository and specifically on this PR, with the update already.

@Kasui92 Kasui92 changed the title Upd zellij themes Updated Zellij themes with new specs May 8, 2025
@dhh dhh merged commit 02ebc1e into basecamp:master May 18, 2025
@dhh
Copy link
Member

dhh commented May 18, 2025

Reverted in #456 with the error message this produced.

@Kasui92 Kasui92 deleted the upd-zellij-themes branch May 18, 2025 18:21
@Kasui92
Copy link
Contributor Author

Kasui92 commented May 19, 2025

Reverted in #456 with the error message this produced.

The error seems to be due to the use of an old version of Zellij and therefore still expects the legacy format (ref). The new format is used since v0.42.0 and makes the legacy format incompatible with all functions (such as the text highlighter).

So those who have not updated Zellij can use the legacy, while those who have installed Omakub since March or have updated it should use the new one.

@dhh
Copy link
Member

dhh commented May 19, 2025

Hmm, I saw this with zellij 0.42.2.

@imsnif
Copy link

imsnif commented May 26, 2025

Hey - I hope it's alright to chime in. It would be cool to see Omakub use the new theme spec (it solves a lot of issues, including but not limited to the text selection contrast).

I glanced briefly at the PR and don't see any issues with it. Would you maybe like to tell me what you're doing to produce this error so I can take a closer look?

@Kasui92
Copy link
Contributor Author

Kasui92 commented May 26, 2025

Hey - I hope it's alright to chime in. It would be cool to see Omakub use the new theme spec (it solves a lot of issues, including but not limited to the text selection contrast).

I glanced briefly at the PR and don't see any issues with it. Would you maybe like to tell me what you're doing to produce this error so I can take a closer look?

I have tried these specs in several installations (using both my fork and the original branch of this PR) and I have not encountered the error above.

I can reopen the change, since I have it ready, and maybe I will try again to test it and find out the problem.

@Kasui92 Kasui92 restored the upd-zellij-themes branch May 27, 2025 13:09
@Kasui92
Copy link
Contributor Author

Kasui92 commented May 27, 2025

Fix the errors found in #469

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants