Space transformations refactor#449
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #449 +/- ##
==========================================
+ Coverage 47.36% 48.39% +1.03%
==========================================
Files 112 118 +6
Lines 5422 5558 +136
==========================================
+ Hits 2568 2690 +122
- Misses 2854 2868 +14 ☔ View full report in Codecov by Sentry. |
oschulz
reviewed
Oct 17, 2024
oschulz
reviewed
Oct 17, 2024
oschulz
requested changes
Oct 17, 2024
Member
|
Let's use |
oschulz
approved these changes
Oct 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR incorporates the changes from PR #409, and also includes structural changes of the type structure for mcmc samplers.
E.g.:
"-Iterator" -> "-State"
"Sampling" and "Tuning" are structs that hold the config data for a MCMC sampling and tuning Process, and for the actual execution of the sampling, "MCMCState", and "TunerState" objects are created that hold the concrete data for the process.