Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust for API changes in AdvancedHMC.jl #470

Merged
merged 2 commits into from
Mar 27, 2025
Merged

Adjust for API changes in AdvancedHMC.jl #470

merged 2 commits into from
Mar 27, 2025

Conversation

Micki-D
Copy link
Collaborator

@Micki-D Micki-D commented Mar 23, 2025

This checks if rand_momentum() from AdvancedHMC.jl is defined and if true uses this over the deprecated rand() method in older versions (<0.7) of AdvancedHMC.jl.

@oschulz
Copy link
Member

oschulz commented Mar 26, 2025

Test failures were due to outdated dependency bounds of MGVI.jl - that's fixed now, let's see if tests pass now.

Copy link

codecov bot commented Mar 26, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 50.08%. Comparing base (c781586) to head (1d959ea).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
ext/ahmc_impl/ahmc_sampler_impl.jl 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #470      +/-   ##
==========================================
- Coverage   50.08%   50.08%   -0.01%     
==========================================
  Files         122      122              
  Lines        5872     5874       +2     
==========================================
+ Hits         2941     2942       +1     
- Misses       2931     2932       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@oschulz oschulz merged commit 7f6e291 into main Mar 27, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants