squashfs, overlay: unmount the rom once nothing is holding it - #16093
Open
aderumier wants to merge 1 commit into
Open
squashfs, overlay: unmount the rom once nothing is holding it#16093aderumier wants to merge 1 commit into
aderumier wants to merge 1 commit into
Conversation
bryanforbes
reviewed
Jul 22, 2026
configgen chdirs into the game's directory to run it and stays there, so with a rom on a squashfs it was still sitting in the mount at unmount time, and umount could only fail with EBUSY: a process cannot unmount its own working directory. Restore the directory on the way out. A game that was killed rather than closed could still leave a process holding the mount while it dies, so fall back to detaching it lazily.
aderumier
force-pushed
the
squashfs-umount-fix
branch
from
July 26, 2026 05:57
d5e3b6a to
0479546
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
configgen chdirs into the game's directory to run it and stays there, so with a rom on a squashfs it was still sitting in the mount at unmount time, and umount could only fail with EBUSY: a process cannot unmount its own working directory. Restore the directory on the way out.
Processes that were killed rather than closed also take a moment to let go of the mount, so retry for a few seconds, then detach lazily: the kernel drops the mount once the last one lets go, which beats leaking it until the next reboot.