Fix Libretro-MAME "offscreenreload" light gun option - #16146
Conversation
…not a command line switch now
|
looks ok, remove all the extra comment though please |
|
Done. Just for future reference, I've got some more light gun related fixes for other retroarch systems working, and I've also bumped the emulator and exposed more options into the ES advanced menu for options that were missing. Is one PR per system OK, or are multiple focused PRs per topic, ie bump emu/gun fix/add options better? |
It is OK yes. But tag me for anything light gun related stuff. |
Disclosure, the fix was found using Claude code.
Light guns work fine in Libretro-MAME as long as the "offscreen reload" option is turned off.
If it's turned on however the game will fail to launch with this error -
As that option has been removed from standalone, and Libretro MAME now.
Instead the offscreen reload is loaded as a helper plugin now, which was already done for standalone MAME in it's generator, so fix is just to apply the same here.
I kept the more conservative fix to only apply it if its MAME system specifically given Claudes comment about the other systems also potentially picking up from this generator as I don't have any of them to test with to be sure if they need this or not.
Tested in a custom build of Batocera v44 source on x86 build with Sinden light gun, offscreen button now working fine in addition to actual shooting off screen still.